Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/zed] fix: update go dependencies #2009

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

okozachenko1203
Copy link
Member

@okozachenko1203 okozachenko1203 commented Oct 22, 2024

oras-go is the main reason.
types.AuthConfig is deprecated in docker v25.x.x.
This causes unit test failure.
/go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig /go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig oras-go is indirect dep belonging to helm.sh/helm/v3. Since v3.15.2, helm uses 1.2.5 oras-go.
Btw, I updated helm to v3.16.2.
here are references.
oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2

fix #2004

Depends-On: #2025

oras-go is the main reason.
types.AuthConfig is deprecated in docker v25.x.x.
This causes unit test failure.
/go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:44:20: undefined: types.AuthConfig
/go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:62:131: undefined: types.AuthConfig
/go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login_tls.go:122:32: undefined: types.AuthConfig
/go/pkg/mod/oras.land/[email protected]/pkg/auth/docker/login.go:54:16: undefined: types.AuthConfig
oras-go is indirect dep belonging to helm.sh/helm/v3.
Since v3.15.2, helm uses 1.2.5 oras-go.
Btw, I updated helm to v3.16.2.
here are references.
oras-project/oras-go#691 oras-project/oras-go#697 https://github.com/helm/helm/releases/tag/v3.15.2
@mnaser
Copy link
Member

mnaser commented Oct 23, 2024

recheck

2 similar comments
@okozachenko1203
Copy link
Member Author

recheck

@mnaser
Copy link
Member

mnaser commented Oct 25, 2024

recheck

@mnaser mnaser added the gate label Oct 25, 2024
@mnaser
Copy link
Member

mnaser commented Oct 25, 2024

recheck

@atmosphere-ci atmosphere-ci bot merged commit 35b4901 into stable/zed Oct 25, 2024
7 checks passed
@atmosphere-ci atmosphere-ci bot deleted the cherry-pick-1987-to-stable-zed branch October 25, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants